On Sun, 1 Nov 2009, Sverre Rabbelier wrote: > Heya, > > On Sun, Nov 1, 2009 at 05:27, Junio C Hamano <gitster@xxxxxxxxx> wrote: > > - Should we fix get_helper() in transport-helper.c, instead of touching > > ls-remote.c like this patch does? > > Probably, yes. If we change the ls-remote.c case, it becomes impossible for a struct transport to ever have a NULL remote field. And the change to ls-remote removes a special case. I'd go so far as to say that ls-remote.c should provide a struct remote, and transport_get should enforce that there's a struct remote. -Daniel *This .sig left intentionally blank*