Junio C Hamano <gitster@xxxxxxxxx> wrote: > I think that is probably too much complexity for too little gain. I think > detecting stale request and having requestor retry would be sufficient, > and validating the want lines as we already do would give the same level > of assurance as "check against the hash of first phase response" I > outlined above, and would be much simpler thus more robust. Ack. I think what we want here is to just add an "ERR invalid want" message just before disconnecting when the client gives us a SHA-1 which we don't point to directly. Client implementations can choose how to handle this error. They could retry from the beginning, or they could abort. -- Shawn. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html