Junio C Hamano wrote: > Jonathan Nieder <jrnieder@xxxxxxxxx> writes: > >> I am a bit uncomfortable with this error in general. It makes some >> sense to refuse to use $VISUAL and fall back to $EDITOR if TERM=dumb, >> since without this the distinction between VISUAL and EDITOR is not >> very useful. > > More importantly, that is what people traditionally expected from VISUAL > and EDITOR and we do that only to follow suit. Unfortunately, we don’t do that: we currently still use $VISUAL if TERM=dumb and just refuse to fall back to vi in that case. I’ll add a patch to fix this. > There is no such tradition for GIT_EDITOR nor core.editor Makes sense. Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html