Michael Wookey schrieb: > 2009/9/28 Johannes Sixt <j.sixt@xxxxxxxxxxxxx>: >> Michael Wookey schrieb: >>> 2009/9/22 Marius Storm-Olsen <mstormo@xxxxxxxxx>: >>>> Michael Wookey said the following on 22.09.2009 11:17: >>>>> 2009/9/22 Marius Storm-Olsen <mstormo@xxxxxxxxx>: >>>>>> Michael, how are you trying to compile git? With the IDE or the >>>>>> GNU Make? Which version of MSVC? If you use the IDE, can you make >>>>>> sure it doesn't contain the UNICODE define in the compiler >>>>>> section of the properties of the projects? >>>>> I'm using the VS 2008 Professional IDE (the solution doesn't open >>>>> in VS 2005). I made no changes to the build settings. In the >>>>> Preprocessor section of the project, UNICODE is defined. >>>> Were these projects generated with the Vcproj generator in >>>> contrib/buildsystem, with the Qmake generator, or the projects from Frank's >>>> repo? >>> The project was generated from the vcproj generator in >>> contrib/buildsystem from git.git/master. >> What's the status of this? > > I was hoping that this gets included into git.git because it fixes a > real issue with MSVC builds. Since Junio is away, perhaps Shawn can > take the patch into his interim tree? > > BTW - would you mind giving this patch an ack? As I said, the patch looks fine. However, in the commit message you say: MSVC builds define UNICODE which results in the "WIDE" variation of Win32 API's being used. But since Marius has built the code without your patch, this justification must be incomplete. I won't give a formal Ack until this is clarified. Please work with Marius to figure out why your build uses UNICODE while Marius's doesn't. -- Hannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html