Re: [PATCH] compat/mingw.c: MSVC build must use ANSI Win32 API's

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Michael Wookey said the following on 22.09.2009 11:17:
2009/9/22 Marius Storm-Olsen <mstormo@xxxxxxxxx>:
Michael, how are you trying to compile git? With the IDE or the
GNU Make? Which version of MSVC? If you use the IDE, can you make
sure it doesn't contain the UNICODE define in the compiler
section of the properties of the projects?

I'm using the VS 2008 Professional IDE (the solution doesn't open
in VS 2005). I made no changes to the build settings. In the
Preprocessor section of the project, UNICODE is defined.

Were these projects generated with the Vcproj generator in contrib/buildsystem, with the Qmake generator, or the projects from Frank's repo?


On another note, I see *many* build warnings for things like "signed/unsigned compares". I'd be willing to work through these warnings and fix them. Thoughts?

Well, first find out why these are a problem with MSVC and not GCC. Are the types different on these platforms? signed vs unsigned should show up with GCC as well. We need to make sure that we don't fix signed/unsigned issues on one platform, just to introduce it to another platform. In any case, it would be good for someone to have a look at these, just so we can determine the cause for most of them, and then we should figure out on the list how to deal with them.

Just my €0.2..

--
.marius
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]