onsdag 23 september 2009 18:42:29 skrev "Halstrick, Christian" <christian.halstrick@xxxxxxx>:
> From: Christian Halstrick <christian.halstrick@xxxxxxx>
>
> JGit should understand configuration parameter logAllRefUpdates and should
> only log updates of refs when
> either the log file for this ref is already present
> or this configuration parameter is set to true
> Before this commit JGit was always writing logs, regardless of this
> parameter or existence of logfiles.
A few minor things:
Format the comment nicely and space betwee paragraphs.
Start the comment with a capital letter
A cover letter for multiple patches is nice, though in this case you could
actually just squash there patches into one patch.
and one major.
RefUpdateTest broke.
Probably because of this.
> + logAllRefUpdates = rc.getBoolean("core", "logAllRefUpdates", false);
According to the git-config man page logAllRefUpdates is true by default for non-bare
repos and false for bare repos.
I had some trouble applying these patches as git-am did not like them. Apparently
git-am doesn't like base64. Could you set your mailer to use a more plain-ish format
or use git-send-email.
-- robin
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html