On Sat, Sep 26, 2009 at 00:05, Shawn O. Pearce <spearce@xxxxxxxxxxx> wrote: > Sebastian Schuberth <sschuberth@xxxxxxxxx> wrote: >> From c6d29a2d243647bb2877eb2114938ae20c8e56e5 Mon Sep 17 00:00:00 2001 >> From: Sebastian Schuberth <sschuberth@xxxxxxxxx> >> Date: Thu, 24 Sep 2009 15:52:25 +0200 >> Subject: [PATCH 1/2] Make generated MSVC solution file open from Windows Explorer >> >> In order to be able to open the generated solution file by double-clicking it >> in Windows Explorer, all project files need to use DOS line-endings and a >> comment about the Visual Studio version needs to be added to the header of the >> solution file. This also fixes the icon that is displayed for the solution file >> in Windows Explorer. >> Note that opening the solution file from a running instance of Visual Studio >> already worked before. > > Something is wrong with both patches; neither applies. It looks > to be an issue with whitespace, like context lines are gaining an > extra space at the start of the line. Hmm, the patches apply fine onto master for me. As a side note, I've never liked sending patches via mail. It just feels like writing a text on a computer just to print it out, scan in the sheet again, and then sending the scanned image as an attachment via email. Isn't there a better way to contribute patches to Git, like pushing to a mob branch as for the msysGit project? -- Sebastian Schuberth -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html