Sam Ravnborg <sam@xxxxxxxxxxxx> writes:
>> @@ -431,6 +431,11 @@ sub send_message
>> $gitversion =~ s/^.* //;
>> }
>>
>> + my ($author_name) = ($from =~ /^(.*?)\s+</);
>> + if ($author_name =~ /\./ && $author_name !~ /^".*"$/) {
>> + my ($name, $addr) = ($from =~ /^(.*?)(\s+<.*)/);
>> + $from = "\"$name\"$addr";
>> + }
>> my $header = "From: $from
>> To: $to
>> Cc: $cc
>>
> I would assume we had to do the same for all mail addresses?
> In this case also for $to and $cc and $reply_to.
I do not think so, although I admit I only had a cursory look at
the code. In this part of the code, $to and $cc are coming from
return value of unique_email_list sub, which cleanses each
address with extract_valid_address sub. This sub does:
A U Thor <foo@xxxxxxx> => foo@xxxxxxx
In other words, I think it is only "$from" that needs it.
I think $to and $cc should not strip out the human-readable name,
but in this case it saved us extra trouble. Sigh...
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html