On Mon, Sep 25, 2006 at 12:43:16AM +0200, Sam Ravnborg wrote: > I stumbled on two issues with git-send-email today. > First of I forgot to tell where to find the patch files to send. > But git-send-email only complained _after_ I had given all > the information manually. > It would have been niver to check that all mandatory arguments > was present before being interactive. > > The second issue are best explained quoting a mail from Matti Arnio: > > > The GIT is at times producing emails that are not > > > utterly strictly speaking kosher RFC-(2)822 format. > > > > > > It might be a surprise to you that unquoted dots in > > > people's names cause syntax scanner indigestion, > > > because said character has very special meaning in > > > RFC-822 syntax. All would be fine if > > > Example J.P. Example <example@xxxxxxxxxxx> > > > had couple quotes: > > > "Example J.P. Example" <example@xxxxxxxxxxx> > > What I could see was that git-send-email takes mail address > verbatim from "Signed-off-by:" lines and use it. The patches in quistion did not have a "Signed-off-by: tag so that mail address has been from the author instead. And this mail address was still invalid as per RFC2822. > Would it be possible to always quote it except when quoted > or to do a more intelligent RFC2822 check? > > That would keep suprises lower. > > I'm not good a perlish so I have not attempted fixing it myself... Sam - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html