Sebastian Schuberth <sschuberth@xxxxxxxxx> writes: > I like the idea of making bswap available more globally, but I'm not > sure if it's worth to introduce a new file for only that purpose. > Isn't there already a central header for such things? > > Moreover, including compat/bswap.h would only give you ntohl()/htonl() > on one platform. We do not include compat/ directly from the source; git-compat-util.h is supposed to be the first thing included (as some platforms have peculiar requirements on the order in which system header files are included, and one of the reasons git-compat-util.h is there). Hence by including it, you get ntohl/htonl everywhere. To reduce confusion, you may want to rename compat/bswap.h to something like compat/ntohl-htonl-fix.h ;-) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html