On Tue, 18 Aug 2009, Junio C Hamano wrote: > Sebastian Schuberth <sschuberth@xxxxxxxxx> writes: > > > On Tue, Aug 18, 2009 at 14:56, Artur Skawina<art.08.09@xxxxxxxxx> wrote: > > ... > >> I'd limit it to windows and any other ia32 platform that doesn't pick the > >> bswaps itself; as is, it just adds an unnecessary hidden gcc dependency. > >> > >> Hmm, it's actually a gcc-4.3+ dependency, so it won't even build w/ gcc 4.2; > >> something like this would be required: "(__GNUC__>=4 && __GNUC_MINOR__>=3)" . > > > > So, as you say the code makes no difference under Linux, would you be > > OK with just testing for GCC 4.3+, and not for Windows? That would get > > rid of the "hidden" GCC dependency and not make the preprocessor > > checks overly complex. Moreover, limiting my patch to any "platform > > that doesn't pick the bswaps itself" could possibly require > > maintenance on compiler / CRT updates. > > I would say that should be fine, but I'd let Linus and Nico to overrule me > on this if they have any input. Well... Given that git already uses ntohl/htonl quite extensively in its core already, I'd suggest making this more globally available instead. Nicolas -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html