Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
> Hi,
>
> On Tue, 18 Aug 2009, Frank Li wrote:
>
>> >> Add unix head file, dirent.h, unistd.h and time.h
>> >
>> > These are copied from somewhere. From where? What is the license?
>>
>> It comes from msys, which used to build msysgit.
>
> I know. After reading the patch. But it would be better if everybody
> knew after reading the commit message... _Especially_ in this
> increasingly lawsuit-defined business, it is very nice to see early that
> the files you are including here are in the public domain, and come from
> MSys.
And there was this line in the snarfed file:
* No warranty is given; refer to the file DISCLAIMER within the package.
but there no DISCLAIMER file (perhaps a separate patch added it, but I
somehow doubt it).
> As I said earlier, there are common flags, but as I also said, it is
> probably better to keep the #define's in a header file for better
> visibility and editability, albeit in logically clustered blocks (i.e. all
> the NO_* and other #define's that affect what source code is
> compiled, all default paths in another cluster, #define's to bow before
> Microsoft's C runtime's decision to deprecate the C99 standard function
> names, etc)
... and that can live in a separate header file to reduce clutter and
shield people who do not need to look at MSC related code, no?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html