Re: [PATCH 09/11] Add MSVC porting header files.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, 18 Aug 2009, Frank Li wrote:

> >> Add unix head file, dirent.h, unistd.h  and time.h
> >
> > These are copied from somewhere.  From where?  What is the license?
> 
> It comes from msys,  which used to build msysgit.

I know.  After reading the patch.  But it would be better if everybody 
knew after reading the commit message...  _Especially_ in this 
increasingly lawsuit-defined business, it is very nice to see early that 
the files you are including here are in the public domain, and come from 
MSys.

> I really want to in .vcproj.  but the same context needs to copy
> DEBUG\RELEASE 32\64bit, libgit.vcproj and git.vcproj. 8 place needs
> copy.  To avoid copy in vcproj file, I move it hear.

As I said earlier, there are common flags, but as I also said, it is 
probably better to keep the #define's in a header file for better 
visibility and editability, albeit in logically clustered blocks (i.e. all 
the NO_* and other #define's that affect what source code is 
compiled, all default paths in another cluster, #define's to bow before 
Microsoft's C runtime's decision to deprecate the C99 standard function 
names, etc)

BTW it is funny that your typos seem to be influenced by the _sound_ of 
the word ("hear" instead of "here"), rather than just simple transposed 
letters... most of my typos are the same ;-)

Ciao,
Dscho

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]