Hi, On Tue, 18 Aug 2009, Frank Li wrote: > Windows will convert CR\LF and union code at text mode. > Git doesn't like this. Add O_BINARY flag to open function > > Signed-off-by: Frank Li <lznuaa@xxxxxxxxx> How about this instead? mingw.c: Use the O_BINARY flag to open files On Windows, non-text files must be opened using the O_BINARY flag. MinGW does this for us automatically, but Microsoft Visual C++ does not. Also, Johannes said that this would be a nice cleanup. BTW what about fopen()? Patch is obviously good. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html