Sverre Rabbelier <srabbelier@xxxxxxxxx> wrote: > This allows the frontend to specify any of the supported options as > long as no non-option command has been given. > --- > > As requested, updated the documentation of the language format > > Documentation/git-fast-import.txt | 23 +++++++++++++++++++++++ > 1 files changed, 23 insertions(+), 0 deletions(-) Why isn't this new 'option' command actually implemented by this patch? Please introduce docs and code in the same patch if you can, especially when it is this simple. > diff --git a/Documentation/git-fast-import.txt b/Documentation/git-fast-import.txt > index c2f483a..6b5bc1b 100644 > --- a/Documentation/git-fast-import.txt > +++ b/Documentation/git-fast-import.txt > @@ -303,6 +303,11 @@ and control the current import process. More detailed discussion > standard output. This command is optional and is not needed > to perform an import. > > +`option`:: > + Specify any of the options listed under OPTIONS to change > + fast-import's behavior to suit the frontends needs. This command > + is optional and is not needed to perform an import. s/frontends/frontend's/ > +`option` > +~~~~~~~~ > +Processes the specified option so that git fast-import behaves in a > +way that suits the front-ends needs. s/front-ends/frontend's/ > +Note that options specified by the frontend override any options the > +user may specify to git fast-import itself. Hmmph. Do we really want that? I would think the command line options should override the stream, such that we can then do something like: hg fast-export >foo git fast-import --export-marks=mymarks <foo even though 'option export-marks=bar' appears in foo. -- Shawn. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html