Re: [RFC PATCH v2 1/4] Prevent diff machinery from examining assume-unchanged entries on worktree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, 11 Aug 2009, Nguyen Thai Ngoc Duy wrote:

> >> +test_expect_success 'diff-index does not examine assume-unchanged entries' '
> >> +     git diff-index HEAD^ -- one | grep -q 5626abf0f72e58d7a153368ba57db4c673c0e171
> >> +'
> >> +
> >> +# TODO ced_uptodate()
> >
> > What is this about?
> 
> It tests "if (ce_uptodate(ce) || (ce->ce_flags & CE_VALID))" and I was 
> pretty sure it hit ce_uptodate() first, so the second expression was not 
> tested.

Ah.  I was distracted by the "d" before the underscore.

ce_uptodate(ce) checks the time stamp amongst other things, right?  How 
about using test-chmtime to force an mtime mismatch?

Ciao,
Dscho

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]