Re: [RFC PATCH v2 1/4] Prevent diff machinery from examining assume-unchanged entries on worktree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2009/8/10 Johannes Schindelin <Johannes.Schindelin@xxxxxx>:
>> +test_expect_success 'setup' '
>> +     echo zero > zero &&
>> +     git add zero &&
>> +     git commit -m zero &&
>> +     echo one > one &&
>> +     echo two > two &&
>> +     git add one two &&
>> +     git commit -m onetwo &&
>> +     git update-index --assume-unchanged one &&
>> +     echo borked >> one &&
>> +     test "$(git ls-files -v one)" = "h one"
>> +'
>
> Maybe use test_commit, to make it more readable?

Thanks. I did not know that (or forgot already). Will use it.

>
>> +
>> +test_expect_success 'diff-index does not examine assume-unchanged entries' '
>> +     git diff-index HEAD^ -- one | grep -q 5626abf0f72e58d7a153368ba57db4c673c0e171
>> +'
>> +
>> +# TODO ced_uptodate()
>
> What is this about?

It tests "if (ce_uptodate(ce) || (ce->ce_flags & CE_VALID))" and I was
pretty sure it hit ce_uptodate() first, so the second expression was
not tested.
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]