That patch was originally mailed on the 11th May. Has it taken until
now to notice the problem, or was the other method added in the last
month or so? If I'm to blame, I apologise but didn't note any compile
time issues at the time.
Alex
Sent from my (new) iPhone
On 10 Aug 2009, at 16:52, "Shawn O. Pearce" <spearce@xxxxxxxxxxx> wrote:
Alex Blewitt <alex.blewitt@xxxxxxxxx> wrote:
---
.../src/org/spearce/jgit/lib/AnyObjectId.java | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/
AnyObjectId.java b/org.spearce.jgit/src/org/spearce/jgit/lib/
AnyObjectId.java
index acb3cb5..015042a 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/AnyObjectId.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/AnyObjectId.java
@@ -448,6 +448,12 @@ public final String name() {
}
/**
+ * @return string form of the SHA-1, in lower case hexadecimal.
+ */
+ public final String getName() {
+ return name();
+ }
Obviously you didn't compile test this in JGit:
./org/spearce/jgit/revwalk/RevTag.java:206: getName() in
org.spearce.jgit.revwalk.RevTag cannot override getName() in
org.spearce.jgit.lib.AnyObjectId; overridden method is final
:-(
--
Shawn.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html