On Tue, Jul 28, 2009 at 1:38 PM, Nicolas Sebrecht<nicolas.s.dev@xxxxxx> wrote: > Hum, you're right. The '@' symbol is required, whatever "id-right" is. > My previous patch should fix it. With all due respect, I don't see how that patch fixes anything. The previous last-resort solution should already be just as valid, it assigns 'user@'+hostname to $du_part. Even if hostname is "" it should insert an '@', which didn't happen here. I'm suspecting that git-send-email in v1.5.2.5 didn't do enough checks, and that this is an already-solved issue. Looking at the source code from v1.5.2.5 seems to confirm this. http://repo.or.cz/w/git.git?a=blob;f=git-send-email.perl;h=7c0c90bd21bbb009de81aa315bed1c947a32c423;hb=b13ef4916ac5a25cc5897f85ba0b4c5953cff609 my $message_id_from = extract_valid_address($from); my $message_id_template = "<%s-git-send-email-$message_id_from>"; sub make_message_id { my $date = time; my $pseudo_rand = int (rand(4200)); $message_id = sprintf $message_id_template, "$date$pseudo_rand"; #print "new message id = $message_id\n"; # Was useful for debugging } So I think it's pretty safe to disregard this as an already solved issue. -- Erik "kusma" Faye-Lund kusmabite@xxxxxxxxx (+47) 986 59 656 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html