Pierre Habouzit <madcoder@xxxxxxxxxx> writes: > On Wed, Jul 22, 2009 at 03:00:21PM -0700, Junio C Hamano wrote: >> Pierre Habouzit <madcoder@xxxxxxxxxx> writes: >> >> > [PATCH 1/3] janitor: use NULL and not 0 for pointers. >> > >> > I really dislike the use of 0 when NULL is meant. This patch probably >> > fixes most of them. The biggest culprit is nedmalloc, but a few >> > remnants exist in plain git code. >> >> I am not enthused about "fixing" borrowed foreign code, unless we know >> that we are committed to support our fork. My impression was that this >> ned stuff was borrowed by the MinGW folks with the understanding that we >> will slurp it with minimum modification and turn a blind eye to its >> sub-par coding styles, so that it can be more easily updated from the >> upstream? > > Okay, maybe the 2-3 hunks that don't apply to nedmalloc stuff can be > saved though, do you want me to send an updated patch ? No, I'll split out that part and queue the rest. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html