On Tue, Jul 21, 2009 at 05:43:08PM -0700, Junio C Hamano wrote: > Note that my suggestion on $PATH=$(git --exec-path):$PATH was a response > to Jeff's message, which was the same message your patch was response to. > In other words, our messages crossed, and I do not have an issue with > fixing this either way. If your patch fixes the issue correctly that > would be great. I am still confused about what the "issue" is. That is, why this is a bugfix for Anthony instead of simply a code modernization. IOW, I think there is something else broken about his install if cvsimport cannot find the dashed plumbing commands, and we may simply be papering over it. That being said, I think the code modernization is of value itself, so let's do it. > Has anybody reviewed the submitted patch? I do not use cvsimport these > days anymore for anything real, so the only assurance I have on your patch > so far are my eyeballs and whatever tests done in test scripts in the t/ > directory. Independent "Yeah, it looks good and it works for me" would > make me feel a bit safer. I am lucky enough not to have needed git-cvsimport for some time, so I cannot say "it works for me." But I have read the patch; I didn't see any errors in the conversion, and assuming the conversion is done correctly, the behavior should be otherwise identical. So Acked-by: Jeff King <peff@xxxxxxxx> -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html