But regardless, surely calling straight into git is simpler/nicer and
more likely to just work (as on OSX)?
From the 1.6.0 release notes (http://www.kernel.org/pub/software/scm/git/docs/RelNotes-1.6.0.txt
):
"""With the default Makefile settings, most of the programs are now
installed outside your $PATH, except for "git", "gitk" and some server
side programs that need to be accessible for technical reasons.
Invoking a git subcommand as "git-xyzzy" from the command line has
been deprecated since early 2006 (and officially announced in 1.5.4
release notes); use of them from your scripts after adding output from
"git --exec-path" to the $PATH is still supported in this release, but
users are again strongly encouraged to adjust their scripts to use
"git xyzzy" form, as we will stop installing "git-xyzzy" hardlinks for
built-in commands in later releases. """
note the "but users are again strongly encouraged to adjust their
scripts to use "git xyzzy" form". Why not just apply the patch and be
done with it?
-Antony
On 21/07/2009, at 3:34 AM, Jeff King wrote:
On Sun, Jul 19, 2009 at 07:43:28PM -0700, Junio C Hamano wrote:
We encourage script writers to just prepend "git --exec-path" at the
beginning of their PATH and give guarantee that this simple
procedure will
keep their scripts working, so it might be a good idea to have an
example
for that as well.
I had it in my head that such a strategy was supposed to be a
temporary
step in the process of getting rid of dashed forms. That is, you can
do
that now to avoid having your scripts break, but in the long run, you
should be converting to the space form.
But I guess the plan was softened, and we have no deprecation plan for
dashed forms in exec-path. So maybe my thinking was outdated.
So the preferred fix might be just the matter of adding one line
$ENV{'PATH'} = `git --exec-path`. ":$ENV{'PATH'}";
at the beginning of the script.
I can see that for a totally third-party script which wanted to use
git
plumbing. But why do that for a git-* script? The "git" wrapper
sets up
the environment like that already.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html