Re: [PATCH] Re: git-am: less strong format "mbox" detection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nicolas Sebrecht <nicolas.s.dev@xxxxxx> writes:

> And why should we accept "From "?

You are going totally in a wrong way around with this.

Berkeley mbox format is what we support, and "From " is the _only_
delimiter between pieces of e-mail in the file.  We happen to allow "From:
" in order to merely be extra nice for people who create mbox looking file
by hand; I think it is an improvement not to require an optional SP after
the colon there, but that is totally an independent issue.

I cannot offhand say if allowing anything but "From:" is necessarily an
improvement, or making the format detection unnecessarily risky of
misidentification.  I do not particularly like the idea of allowing only
some randomly selected fields like Return-Path and Delibered-To and not
accepting others, let alone totally nonstandard X-Foo fields.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]