Re: [PATCH] git-am: less strong format "mbox" detection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 14, 2009 at 8:40 AM, Nicolas Sebrecht<ni.s@xxxxxxxxxxx> wrote:
> Thunderbird (v1.* at least) likes to start e-mails with "X-Account-Key:".
> Also, I have some emails starting with "Return-Path:" or ""Delivered-To:".
>
> Signed-off-by: Nicolas Sebrecht <ni.s@xxxxxxxxxxx>
> ---
>  git-am.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/git-am.sh b/git-am.sh
> index d64d997..d10a8e0 100755
> --- a/git-am.sh
> +++ b/git-am.sh
> @@ -169,7 +169,7 @@ check_patch_format () {
>                read l2
>                read l3
>                case "$l1" in
> -               "From "* | "From: "*)
> +               "From "* | "From: "* | "X-Account-Key:"* | "Return-Path:"* | "Delivered-To:"*)

Nitpick: for consistency, should we either expect a space after the
colon also in the new keys, or not expect i in the From: key either. I
don't think the RFC requires a space, but most clients probably add
it.

-- 
Giuseppe "Oblomov" Bilotta
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]