Re: [PATCH] quickfetch(): Prevent overflow of the rev-list command line

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 8, 2009 at 18:01, Johan Herland<johan@xxxxxxxxxxx> wrote:
> On Wednesday 08 July 2009, Johannes Sixt wrote:
>> ... don't you get this error message with errno set to EPIPE?
>> Previously, there was no error message.
>
> Indeed, you are correct. I guess the following should be added to the
> patch:
>
>        if (write_in_full(revlist.in, sha1_to_hex(ref->old_sha1), 40) < 0 ||
>            write_in_full(revlist.in, "\n", 1) < 0) {
> -               error("failed write to rev-list");
> -               err = errno;
> +               if (errno != EPIPE) {
> +                       error("failed write to rev-list");
> +                       err = errno;

You'll loose errno this way: error() does not save it.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]