Hi,
i have checked the source base of git with the static code analyis tool cppcheck. It brougt up an issue in file 1.6.3.3/builtin-fast-export.c at line 447.
The tool printed the following waring:
[git-1.6.3.3/builtin-fast-export.c:447]: (error) Resource leak: f
I have attached a patch to resolve this.
Best regards
Ettl Martin
--
Neu: GMX Doppel-FLAT mit Internet-Flatrate + Telefon-Flatrate
für nur 19,99 Euro/mtl.!* http://portal.gmx.net/de/go/dsl02
--- git-1.6.3.3/builtin-fast-export.c 2009-06-22 08:24:25.000000000 +0200
+++ git-1.6.3.3/builtin-fast-export_new.c 2009-07-09 09:44:28.000000000 +0200
@@ -442,8 +442,9 @@ static void export_marks(char *file)
deco++;
}
- if (ferror(f) || fclose(f))
+ if (ferror(f))
error("Unable to write marks file %s.", file);
+ fclose(f);
}
static void import_marks(char *input_file)