2009/6/25 Jakub Narebski <jnareb@xxxxxxxxx>: > Giuseppe Bilotta wrote: > >> Significant changes from the previous iteration are: >> >> * the feature has been renamed to 'avatar', and 'gravatar' is a possible >> value for it (currently the only sensible value, other than ''); > > By the way, I think it might be better solution to provide picon URL > as 'default' attribute for gravatar URL, so it is used if there is no > gravatar for given email. I was thinking about some form of fallback like that too, but I haven't the slightest idea how picons work, so I'm afraid I'll leave that enhancement to some later time. >> * the last patch adds avatars to signoff lines. > > Perhaps it would be better to add gravatars at beginning of line? I'm not sure. As I mention in the email for that commit, I'm totally not satisfied with the layout. I'm lookint into turning signoff blocks into tables. > I'll try to post my comments today (i.e. within 24 hours)... but it > looks good. Thanks a lot. -- Giuseppe "Oblomov" Bilotta -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html