Re: [PATCHv6 0/8] gitweb: gravatar support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Giuseppe Bilotta wrote:

> Significant changes from the previous iteration are:
> 
> * the feature has been renamed to 'avatar', and 'gravatar' is a possible
>   value for it (currently the only sensible value, other than '');

By the way, I think it might be better solution to provide picon URL
as 'default' attribute for gravatar URL, so it is used if there is no
gravatar for given email.

> * the last patch adds avatars to signoff lines.

Perhaps it would be better to add gravatars at beginning of line?


I'll try to post my comments today (i.e. within 24 hours)... but it
looks good.

-- 
Jakub Narebski
Poland
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]