On Thu, Jun 25, 2009 at 12:02 AM, Junio C Hamano<gitster@xxxxxxxxx> wrote: > Giuseppe Bilotta <giuseppe.bilotta@xxxxxxxxx> writes: > >> Views which contain many occurrences of the same email address (e.g. >> shortlog view) benefit from not having to recalculate the MD5 of the >> email address every time. >> --- > > Sign-off? Duh. > I think the cache is placed at the wrong level (it doesn't have to be a > GRavatar_url_cache, but can be a general avatar_url_cache). I'm not sure about it. The URL depends on email and size (can you use arrays as hash keys in Perl?) , and the email part might be the same but the size part might differ across separate calls (in theory; in practice avatars in a view are presently all the same size; but for example if we were to autodetect email addresses in commit messages, we might have both single- and double- sided avatars in the same page). By hashing on email+size only we would lose the benefit of cache when using the same avatar at separate sizes. -- Giuseppe "Oblomov" Bilotta -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html