Giuseppe Bilotta <giuseppe.bilotta@xxxxxxxxx> writes:
> Views which contain many occurrences of the same email address (e.g.
> shortlog view) benefit from not having to recalculate the MD5 of the
> email address every time.
> ---
Sign-off?
I think the cache is placed at the wrong level (it doesn't have to be a
GRavatar_url_cache, but can be a general avatar_url_cache).
IOW,
our %avatar_url_cache = ();
sub git_get_avatar {
...
my $url;
if (!exists $avatar_url_cache{$email}) {
if ($git_gravatar_enabled) {
$url = ... gravatar stuff ...;
} else if ($git_whatever_enabled) {
$url = ... other stuff ...;
}
$avatar_url_cache{$email} = $url;
}
$url = $avatar_url_cache{$email};
if (defined $url) {
return ... prefix then $url then suffix ...;
} else {
return "";
}
}
But the basic idea is sound, I think.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html