Re: [PATCH v3 2/2] rebase -i: save only original commit sha1 to save author information

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, 22 Jun 2009, Jakub Narebski wrote:

> Christian Couder wrote:
> 
> > +                       GIT_AUTHOR_NAME="$author_ident_name" \
> > +                       GIT_AUTHOR_EMAIL="$author_ident_email" \
> > +                       GIT_AUTHOR_DATE="$author_ident_date" \
> >                         $USE_OUTPUT git commit --no-verify \
> >                                 $MSG_OPT "$EDIT_OR_FILE" || failed=t
> 
> Why not use 'git commit -C $(cat "$SAVED_COMMIT") ...' ?

Unfortunately, the quoted part lacks context, so I can only guess that the 
issue is "squash".  You need to retain authorship, but want to present a 
message to the user that is in no commit yet.  And no, constructing a new 
commit for the purpose of passing it to "commit -C" would be way too 
shabby coding IMO.

Ciao,
Dscho

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]