Re: [PATCH v2 2/6] add a test for git-send-email for threaded mails without chain-reply-to

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Markus Heidelberg <markus.heidelberg@xxxxxx> writes:

>> What can be done to make the test better?
>
> Is this change sufficient? Dumping the stdout into a file and grepping
> this.

Yup, that is better for test scripts.

>
>
>  t/t9001-send-email.sh |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
> index ce26ea4..8f810ab 100755
> --- a/t/t9001-send-email.sh
> +++ b/t/t9001-send-email.sh
> @@ -621,4 +621,15 @@ test_expect_success 'in-reply-to but no threading' '
>  	grep "In-Reply-To: <in-reply-id@xxxxxxxxxxx>"
>  '
>  
> +test_expect_failure 'threading but no chain-reply-to' '
> +	git send-email \
> +		--dry-run \
> +		--from="Example <nobody@xxxxxxxxxxx>" \
> +		--to=nobody@xxxxxxxxxxx \
> +		--thread \
> +		--nochain-reply-to \
> +		$patches $patches >stdout &&
> +	grep "In-Reply-To: " stdout
> +'
> +
>  test_done
> -- 
> 1.6.3.2.220.gb421
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]