Re: [PATCH 2/6] add a test for git-send-email for threaded mails without chain-reply-to

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano, 08.06.2009:
> Markus Heidelberg <markus.heidelberg@xxxxxx> writes:
> 
> > +test_expect_failure 'threading but no chain-reply-to' '
> > +	git send-email \
> > +		--dry-run \
> > +		--from="Example <nobody@xxxxxxxxxxx>" \
> > +		--to=nobody@xxxxxxxxxxx \
> > +		--thread \
> > +		--nochain-reply-to \
> > +		$patches $patches |
> > +	grep "In-Reply-To: "
> > +'
> 
> Thanks, but this is not a very good style, as it won't catch if "git
> send-email" dumps core or otherwise fails, exiting with a non-zero status.
> 
> Same comments applies to [PATCH 4/6] as well.

OK, this was my first attempt in writing a test and I just used the last
test 'in-reply-to but no threading' as template.

What can be done to make the test better?

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]