On Mon, 8 Jun 2009, Nick Edelen wrote: > man I can sure be blind at times... alright fixed the latter two > comments. I changed the test file because that particular test wanted > upload-pack to fail through the revision walker, which it could only > now do if shallow objects were involved. OK. However, since now we have 2 different paths for creating object list instead of only one (the existing one in upload-pack and the one in pack-objects), I'd prefer if you could add another test case to make sure the pack-objects path also fails appropriately. The rest looks fine to me, and with the test issue fixed you could add my: Acked-by: Nicolas Pitre <nico@xxxxxxx to your next submission. Oh and you might change the subject prefix to [PATCH] as well since I think this won't be WIP anymore. Nicolas -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html