On Samstag, 6. Juni 2009, Thomas Rast wrote: > Johannes Sixt wrote: > > On Samstag, 6. Juni 2009, Thomas Rast wrote: > > > + > > > + va_end(params); > > > > This va_end should better be before die(). > > Not that I object to changing it, but out of curiosity, what do I > break by putting it after? I don't know, and I suspect that in practice nothing breaks. It's just a matter of style: va_start acquires a "resource", and va_end releases it, and you should do that as soon as possible after the "resource" is no longer needed. -- Hannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html