Johannes Sixt wrote:
> On Samstag, 6. Juni 2009, Thomas Rast wrote:
> > +void die_errno(const char *err, ...)
> > +{
> > + va_list params;
> > + char msg[1024];
> > +
> > + va_start(params, err);
> > +
> > + vsnprintf(msg, sizeof(msg), err, params);
> > + die("%s: %s", msg, strerror(errno));
>
> Cannot vsnprintf potentially modify errno?
Manpage turns up nothing, so AFAICT, no.
> > +
> > + va_end(params);
>
> This va_end should better be before die().
Not that I object to changing it, but out of curiosity, what do I
break by putting it after?
--
Thomas Rast
trast@{inf,student}.ethz.ch
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html