Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: >> As to the second one, I think you lost "even if we happen to" part (that >> logically corresponds to "... that is why we do not want to limit the >> inclusion to !__MINGW32__ case") from the description, making it less >> readable... > > You mean "even if we happen to be on Windows"? I meant this part from your earlier message. > It helps in that malloc.h is included even if we happen to compile the > stuff as a MinGW program. Otherwise necessary function declarations are > missing. compared with the newer "how about" version, which is >> > Also, with the version of MinGW's headers in msysGit, we need to include >> > malloc.h lest the compiler complain about an "incompatible implicit >> > declaration of built-in function 'alloca'". I thought the former explains the change in question >> > -#if defined(WIN32) && !defined(__MINGW32__) >> > +#if defined(WIN32) much more clearly: "If you are compiling for Windows, regardless of MINGW32, you would want this section to apply". > ... Want me to resend a fixed patch? Surely. I think I could come up with something based on the discussion here, but I'd rather not. A patch signed off by either you or Steffen, or both is very much appreciated. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html