Hi, On Tue, 2 Jun 2009, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > > Okay, how about this in the commit body in addition? > > > > -- snip -- > > Nedmalloc's source code has a cute #define construct to avoid inserting > > an if() statement, because that might interact badly with enclosing if() > > statements. However, there is no danger of that now, but GCC > 4 > > complains "warning: value computed is not used". > > > > Also, with the version of MinGW's headers in msysGit, we need to include > > malloc.h lest the compiler complain about an "incompatible implicit > > declaration of built-in function 'alloca'". > > -- snap -- > > > > Hmm? > > As to the first one, I think your problem description is clear (the > problem is clear without being explained to begin with) but "there is no > danger of that now" is somewhere between a lame excuse for not doing it > the right way and a bug waiting to happen. If "value computed is not > used" is the issue, why doesn't this work? > > #define ensure_initialization() (void)(mparams.magic != 0 || init_mparams()) That works. > As to the second one, I think you lost "even if we happen to" part (that > logically corresponds to "... that is why we do not want to limit the > inclusion to !__MINGW32__ case") from the description, making it less > readable... You mean "even if we happen to be on Windows"? Fine with me. Want me to resend a fixed patch? Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html