Re: [PATCH v4 2/2] diff: generate pretty filenames in prep_temp_blob()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 29, 2009 at 06:22:05PM -0700, David Aguilar wrote:

> > This is such an easily-factorable bit, maybe it makes sense to add as
> > basename() in compat/?
> 
> I would feel a little better calling it
> git_basename(const char *) and keeping it in path.c
> [...]
> All this version cares about is being able to find the
> last dir_sep and returning a pointer.
> 
> What do you think?

That sounds good to me.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]