On Thu, May 28, 2009 at 05:49:24PM -0700, David Aguilar wrote:
> @@ -1964,8 +1964,24 @@ static void prep_temp_blob(const char *path, struct diff_tempfile *temp,
> {
> int fd;
> struct strbuf buf = STRBUF_INIT;
> + struct strbuf template = STRBUF_INIT;
> + char *basename = ((char*)path) + strlen(path) - 1;
Why do you drop constness in this assignment?
> + /* Windows lacks basename() */
> + while(*basename && basename > path) {
> + basename--;
> + if (is_dir_sep(*basename)) {
> + basename++;
> + break;
> + }
> + }
This is such an easily-factorable bit, maybe it makes sense to add as
basename() in compat/?
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html