Re: [PATCH] gitk: use --textconv to generate diff text

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff King <peff@xxxxxxxx> writes:

> On Mon, May 11, 2009 at 09:18:56AM +0200, Johannes Sixt wrote:
>
>> For the most part gitk's focus is on showing history and changes in
>> a human readable form. For this reason, it makes sense to generate
>> the patch text in the diff view using --textconv so that textconv drivers
>> are used if they are defined.
>> 
>> gitk can also generate patches, but we do not use --textconv because
>> such patches could not be applied.
>> 
>> Signed-off-by: Johannes Sixt <j6t@xxxxxxxx>
>
> As the original author of the textconv code, I am in favor of this.

I agree; I think textconv is meant for this kind of usage.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]