On Mon, May 11, 2009 at 09:18:56AM +0200, Johannes Sixt wrote: > For the most part gitk's focus is on showing history and changes in > a human readable form. For this reason, it makes sense to generate > the patch text in the diff view using --textconv so that textconv drivers > are used if they are defined. > > gitk can also generate patches, but we do not use --textconv because > such patches could not be applied. > > Signed-off-by: Johannes Sixt <j6t@xxxxxxxx> As the original author of the textconv code, I am in favor of this. So much so that I even posted basically the same patch before: http://article.gmane.org/gmane.comp.version-control.git/102523 I had trouble finding much discussion in the archive, but I think it may not have been taken because we were in release freeze (and textconv was a brand new feature in the release at the time). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html