Re: [PATCH 2/2] pack-objects: report actual number of threads to be used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 5 Apr 2009, Dan McGee wrote:

> On Sun, Apr 5, 2009 at 9:31 PM, Nicolas Pitre <nico@xxxxxxx> wrote:
> > The number currently displayed has real meaning: this is the number of
> > threads git is allowed to use.  The number of threads it will actually
> > use is variable and it changes with time.
> 
> Would something like this be more ideal then? I wouldn't be so
> persistent here if the current text wasn't misleading in a case like
> the following:
> 
> dmcgee@galway ~/projects/devtools (master)
> $ git push origin
> Counting objects: 13, done.
> Delta compression using 4 threads.
> Compressing objects: 100% (8/8), done.
> Writing objects: 100% (8/8), 1.28 KiB, done.
> Total 8 (delta 6), reused 0 (delta 0)
> To archlinux.org:/srv/projects/git/devtools.git
>    bcb0e39..ea73c2b  master -> master
> 
> diff --git a/builtin-pack-objects.c b/builtin-pack-objects.c
> index 9fc3b35..99181fd 100644
> --- a/builtin-pack-objects.c
> +++ b/builtin-pack-objects.c
> @@ -1612,7 +1612,7 @@ static void ll_find_deltas(struct object_entry
> **list, unsigned list_size,
>                 return;
>         }
>         if (progress > pack_to_stdout)
> -               fprintf(stderr, "Delta compression using %d threads.\n",
> +               fprintf(stderr, "Delta compression using up to %d threads.\n",
>                                 delta_search_threads);
> 
>         /* Partition the work amongst work threads. */

This I have absolutely no issue with.

Acked-by: Nicolas Pitre <nico@xxxxxxx>


Nicolas

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]