--- Jakub Narebski <jnareb@xxxxxxxxxxxxxxxxxxx> wrote:
> From: Jakub Narebski <jnareb@xxxxxxxxx>
>
> Fix regression introduced by
> commit 17d07443188909ef5f8b8c24043cb6d9fef51bca.
>
> "a.list" being "bold", makes a myriad of things shown by
> gitweb in bold font-weight, which is a regression from
> pre-17d07443188909ef5f8b8c24043cb6d9fef51bca behavior.
>
> The fix is to add "subject" class and use this class
> to replace pre-format_subject_html formatting of subject
> (comment) via using (or not) <b>...</b> element. This
> should go back to the pre-17d0744318... style.
>
> Regression noticed by Luben Tuikov.
>
> Signed-off-by: Jakub Narebski <jnareb@xxxxxxxxx>
> Signed-off-by: Luben Tuikov <ltuikov@xxxxxxxxx>
> ---
ACK. Looks good.
Luben
> Luben Tuikov wrote:
>
> > 1. Commit 17d07443188909ef5f8b8c24043cb6d9fef51bca defines
> > "a.list" twice in gitweb.css, once with bold and once with
> > normal font-weight.
>
> "table.tags a.list" means "a.list" inside "table.tags",
> so it is not redefinition of "a.list", but override
> (more specific CSS rule wins). It is for subject of tags
> list ("summary" and "tags" actions) to be in normal
> weight, as in such list the tag itself (ref) is in bold,
> not the tag comment (first line of free form part of tag).
>
> gitweb/gitweb.css | 7 +++++--
> gitweb/gitweb.perl | 4 ++--
> 2 files changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/gitweb/gitweb.css b/gitweb/gitweb.css
> index 9013895..6c13d9e 100644
> --- a/gitweb/gitweb.css
> +++ b/gitweb/gitweb.css
> @@ -117,11 +117,14 @@ div.list_head {
>
> a.list {
> text-decoration: none;
> - font-weight: bold;
> color: #000000;
> }
>
> -table.tags a.list {
> +a.subject {
> + font-weight: bold;
> +}
> +
> +table.tags a.subject {
> font-weight: normal;
> }
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 90157d5..40c5177 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -504,11 +504,11 @@ sub format_subject_html {
> $extra = '' unless defined($extra);
>
> if (length($short) < length($long)) {
> - return $cgi->a({-href => $href, -class => "list",
> + return $cgi->a({-href => $href, -class => "list subject",
> -title => $long},
> esc_html($short) . $extra);
> } else {
> - return $cgi->a({-href => $href, -class => "list"},
> + return $cgi->a({-href => $href, -class => "list subject"},
> esc_html($long) . $extra);
> }
> }
> --
> 1.4.1.1
>
> -
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html