On 8/17/06, Junio C Hamano <junkio@xxxxxxx> wrote:
Jakub Narebski <jnareb@xxxxxxxxx> writes:
> Expand href() function to use key name of params hash as a query param
> name, if there is no mapping for given key name.
>
> It is now safer to use href(); no errors, but links might not work
> correctly if caller didn't provide correct arguments.
>
> Future proofing.
I think that is not a "future proofing" but is "sweeping mess
under the rug" ;-).
At least leave 'if (exists $mapping{$_})' even if you remove the 'else' part.
[...]
Obviously unrelated and probably unplanned revert of [2/7] in
the series, so will not apply.
Ooops, sorry, I haven't noticed this... Very unplanned.
--
Jakub Narebski
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html