Jakub Narebski <jnareb@xxxxxxxxx> writes:
> Expand href() function to use key name of params hash as a query param
> name, if there is no mapping for given key name.
>
> It is now safer to use href(); no errors, but links might not work
> correctly if caller didn't provide correct arguments.
>
> Future proofing.
I think that is not a "future proofing" but is "sweeping mess
under the rug" ;-).
> @@ -1174,66 +1179,6 @@ sub git_print_page_path {
> }
> }
>
> -sub git_print_log {
> - my $log = shift;
> -
> - # remove leading empty lines
>...
> -}
> -
> -sub git_print_simplified_log {
> - my $log = shift;
> - my $remove_title = shift;
> -
>...
> - print "<br/>\n" unless $empty;
> -}
> -
> ## ......................................................................
> ## functions printing large fragments of HTML
>...
> @@ -2215,10 +2160,27 @@ sub git_log {
> "<br/>\n" .
> "</div>\n" .
> "<i>" . esc_html($co{'author_name'}) . " [$ad{'rfc2822'}]</i><br/>\n" .
> - "</div>\n";
> -
> - print "<div class=\"log_body\">\n";
> - git_print_simplified_log($co{'comment'});
> + "</div>\n" .
> + "<div class=\"log_body\">\n";
>...
> + print format_log_line_html($line) . "<br/>\n";
> + }
> + if (!$empty) {
> + print "<br/>\n";
> + }
> print "</div>\n";
> }
Obviously unrelated and probably unplanned revert of [2/7] in
the series, so will not apply.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html