hoi :)
On Wed, Aug 02, 2006 at 02:13:51PM +1200, Martin Langhoff wrote:
> On 8/2/06, Junio C Hamano <junkio@xxxxxxx> wrote:
> >I do not think there is much difference between any of the
> >customization proposed so far (yours, Martin's and the one from
> >Matthias Lederhofer) from functionality and ease-of-use point of
> >view. They all try to make customization can be done in one
> >place, and the difference is mostly of taste, so I'd just pick
> >one from Martin
>
> I'm a bit lost as to gitweb config. Are we not relying on %ENV for
> this stuff? Apache's facilities to configure CGIs via ENV are really
> powerful. You can do conditionals in apache config files, lock stuff
> down in httpd.conf, override it with files in conf.d, and
> allow/disallow overrides in .htaccess ...
we could make the default use %ENV.
Something like (in Makefile):
GITWEB_SITENAME = $$ENV{GITWEB_SITENAME}
GITWEB_PROJECTROOT = $$ENV{GITWEB_SITENAME} || "/pub/git"
...
and then change gitweb to not put the expanded config values into
quotes. So:
our $projectroot = @@GITWEB_PROJECTROOT@@;
This approach would allow both built-time or run-time configuration of
gitweb.
--
Martin Waitz
Attachment:
signature.asc
Description: Digital signature