Re: [PATCH] Beautifulise git-show output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Why?

A patch like this needs to be justified with a bit more
explanation; the word "beautiful" is subjective.

(current)
	Change this and that file

        Signed-off-by: A U Thor <a.u.thor@xxxxxxxxxxx>
	---
         this-file |   20 +++++++----
	 that-file |    4 ++++
	 2 files changed, 20 insertions(+), 4 deletions(-)

        diff --git a/this-file b/this-file
	...
 
(yours -- and I think 1.3.0 did it like this)
	Change this and that file

        Signed-off-by: A U Thor <a.u.thor@xxxxxxxxxxx>

	---
         this-file |   20 +++++++----
	 that-file |    4 ++++
	 2 files changed, 20 insertions(+), 4 deletions(-)

        diff --git a/this-file b/this-file
	...
 
It _might_ be easier to read if it were like this, though:
 
	Change this and that file

        Signed-off-by: A U Thor <a.u.thor@xxxxxxxxxxx>
	---

         this-file |   20 +++++++----
	 that-file |    4 ++++
	 2 files changed, 20 insertions(+), 4 deletions(-)

        diff --git a/this-file b/this-file
	...

However, the screen real estate, especially in the vertical
direction, is a scarce resource; I do not think the three-dash
is a too weak visual separator that needs to be helped by an
extra newline.

-
: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]