Hi, On Mon, 3 Jul 2006, Linus Torvalds wrote: > On Mon, 3 Jul 2006, Johannes Schindelin wrote: > > > > Traversing is actually wrong. Clearing the marks does not mean to clear > > them on commits we did not even mark! > > If we didn't mark them, then clearing them would be a no-op, so nobody > really cares. My point being: if we try to clear commits we could not have possibly marked, because they were not yet parsed, this is wrong. Basically, I wanted to make the same point as you: > This is why it is _wrong_ to care about the "parsed" bit when clearing the > flags. I will have another look at the users of clear_commit_marks() tomorrow. Ciao, Dscho - : send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html