Re: [PATCH 2nd try] Make git-fmt-merge-msg a builtin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, 3 Jul 2006, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
> 
> > Signed-off-by: Johannes Schindelin <Johannes.Schindelin@xxxxxx>
> >
> > ---
> > 	This retires git-fmt-merge-msg.perl, since it passes all the
> > 	tests, but removes the Perl version not now.
> 
> There is no point not removing the script if you update git.c
> and Makefile to point at the new one.

I should have put PATH/RFC. I did not want to remove the script right 
away, so people could compare outputs (like Martin did with 
git-format-patch).

> We do not have a test specific for fmt-merge-msg, so it
> obviously passes all the tests ;-).  A new one is attached.

Well, t4013 showed me two output bugs, but it evidently did not check for 
merge.summary.

> I think we should extend boolean to accept 'yes' and 'no',

In that case, could we have "YesPlease", "oui", "si" and "da", too? ;-)

Ciao,
Dscho

-
: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]